protocol: add meta.mentions.label #152
Conversation
|
@toolmantim did you imagine any other fields we may want to customize? eg the message when there are no results. My imagination is also really bad at what text we would actually use instead of "Search..." for each provider. Mind giving some examples? @sourcegraph/noodle what do you think of this change to the protocol? Unsure its a good name. Also I keep admiring the choice of |
I think just this single static label is fine for now. Down the track, we may want to allow the provider to change the label based whenever mentions is called, e.g. "Invalid Google Docs URL. Paste a valid URL..." There's an interesting case of multi-step providers too, like Remote Files that @thenamankumar added. For Remote Files it would be something like "Search or choose a repository..." and then "Search or choose a file..." |
The intention behind this field is this is the placeholder label that is shown when a user selects a provider for mentioning, but before they have searched anything.
|
I didn't update hello-world, that provider doesn't implement mentions and needs a little bit of love for another PR. I also didn't update if we will use the default label of "Search..."
This actually takes in a normal sourcegraph query not a URL. |
I did this by running this command
git show --stat | \
grep -o 'provider/[^/]*' | \
sort | uniq | \
while read dir; do pushd $dir; npm version patch; popd; done
pnpm biome
The intention behind this field is this is the placeholder label that is shown when a user selects a provider for mentioning, but before they have searched anything.
Part of https://linear.app/sourcegraph/issue/CODY-2275/add-all-the-right-labels-for-provider-mentions-query-stats