Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories to use sourcegraph/sourcegraph-public-snapshot #209

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

peterguy
Copy link
Contributor

@peterguy peterguy commented Oct 18, 2024

sourcegraph/sourcegraph went private, so links and references became invalid.

I noticed the stale links in https://openctx.org/docs/clients/sourcegraph first: the example files are all linked to sourcegraph/sourcegraph, pinned to a commit.

This is one of the examples: SignInPage.tsx

@peterguy peterguy requested a review from sqs October 18, 2024 21:27
@peterguy peterguy self-assigned this Oct 18, 2024
Comment on lines -21 to +22
- [Example code file on GitHub](https://github.com/sourcegraph/sourcegraph/blob/main/cmd/repo-updater/internal/repoupdater/observability.go)
- [Example pull request on GitHub](https://github.com/sourcegraph/sourcegraph/pull/58878/files)
- [Example code file on GitHub](https://github.com/sourcegraph/sourcegraph-public-snapshot/blob/main/internal/repoupdater/client.go)
- [Example pull request on GitHub](https://github.com/sourcegraph/sourcegraph-public-snapshot/pull/58878/files)
Copy link
Contributor Author

@peterguy peterguy Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqs cmd/repo-updater/internal/repoupdater/observability.go was deleted. I poked around a bit and chose internal/repoupdater/client.go somewhat arbitrarily. If you know of a better one, we can use that one instead.

@sqs
Copy link
Member

sqs commented Oct 19, 2024

Also need to make the new SvelteKit UI support OpenCtx for some of the links to work, but this is definitely an improvement.

@sqs sqs merged commit 0eb3961 into main Oct 19, 2024
13 checks passed
@sqs sqs deleted the peterguy/update-to-sourcegraph-public-snapshot branch October 19, 2024 02:32
bevzzz pushed a commit to bevzzz/openctx that referenced this pull request Dec 12, 2024
…ourcegraph#209)

`sourcegraph/sourcegraph` went private, so links and references became
invalid.

I noticed the stale links in
https://openctx.org/docs/clients/sourcegraph first: the example files
are all linked to `sourcegraph/sourcegraph`, pinned to a commit.

This is one of the examples:
[SignInPage.tsx](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@6cdadefe437e0c7a1afe28da424982ebe72b3654/-/blob/client/web/src/auth/SignInPage.tsx)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants