Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean_flicker_noise option to NIRCam imaging notebook #52

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

drlaw1558
Copy link
Collaborator

This PR adds a commented-out call to the new clean_flicker_noise step to the NIRCam imaging notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drlaw1558
Copy link
Collaborator Author

@bhilbert4 @aliciacanipe A user pointed out that the NIRCam notebook was missing an example of how to run the clean_flicker_noise step. I've added this is so that we can point people to it when we announce these notebooks in the near future. Since the step is commented out there should be no impact on the example notebook run.

Can one of you please take a look and review?

@drlaw1558 drlaw1558 marked this pull request as ready for review February 25, 2025 17:18
@drlaw1558 drlaw1558 requested a review from a team as a code owner February 25, 2025 17:18
Copy link
Contributor

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@drlaw1558 drlaw1558 merged commit 76fe491 into spacetelescope:main Feb 25, 2025
4 checks passed
@drlaw1558 drlaw1558 deleted the nircam_clean_flicker branch February 26, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants