Refactor: resolve comment

sparcs-kaist · Sep 24, 2023 · 560b174 · 560b174
1 parent fbf7cc9
commit 560b174
Showing 1 changed file with 19 additions and 23 deletions.
diff --git a/src/lottery/services/publicNotice.js b/src/lottery/services/publicNotice.js
@@ -130,7 +130,7 @@ const getTicketLeaderboardHandler = async (req, res) => {
       );
 
     const isExponential =
-      sortedUsers.find((user) => user.weight >= weightSum / 15) != undefined;
+      sortedUsers.find((user) => user.weight >= weightSum / 15) !== undefined;
     const base = isExponential
       ? Math.pow(1 - 15 / users.length, users.length / weightSum)
       : null;
@@ -162,28 +162,24 @@ const getTicketLeaderboardHandler = async (req, res) => {
         .status(500)
         .json({ error: "PublicNotice/Leaderboard : internal server error" });
 
-    if (rank >= 0)
-      res.json({
-        leaderboard,
-        totalTicket1Amount,
-        totalTicket2Amount,
-        totalUserAmount: users.length,
-        rank: rank + 1,
-        probability: sortedUsers[rank].weight / weightSum,
-        probabilityV2: calculateProbabilityV2(
-          users,
-          weightSum,
-          base,
-          sortedUsers[rank].weight
-        ),
-      });
-    else
-      res.json({
-        leaderboard,
-        totalTicket1Amount,
-        totalTicket2Amount,
-        totalUserAmount: users.length,
-      });
+    res.json({
+      leaderboard,
+      totalTicket1Amount,
+      totalTicket2Amount,
+      totalUserAmount: users.length,
+      ...(rank >= 0
+        ? {
+            rank: rank + 1,
+            probability: sortedUsers[rank].weight / weightSum,
+            probabilityV2: calculateProbabilityV2(
+              users,
+              weightSum,
+              base,
+              sortedUsers[rank].weight
+            ),
+          }
+        : {}),
+    });
   } catch (err) {
     logger.error(err);
     res