Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#270 안 읽은 메세지 확인 #305

Merged
merged 28 commits into from
Sep 24, 2023
Merged

#270 안 읽은 메세지 확인 #305

merged 28 commits into from
Sep 24, 2023

Conversation

chlehdwon
Copy link
Contributor

@chlehdwon chlehdwon commented May 29, 2023 •
edited
Loading

Summary

It closes #270

Further Work

  • 채팅에서 안 읽은 사람 수 확인

@chlehdwon chlehdwon marked this pull request as draft May 29, 2023 15:48
@chlehdwon chlehdwon self-assigned this May 29, 2023
@chlehdwon chlehdwon changed the title #273 안 읽은 메세지 확인 #270 안 읽은 메세지 확인 Jul 19, 2023
chlehdwon added 12 commits August 9, 2023 14:49
@chlehdwon
Merge branch 'dev' of https://github.com/sparcs-kaist/taxi-back into #…
9186492 
…273-안-읽은-메세지-확인
@chlehdwon
Merge branch 'dev' of https://github.com/sparcs-kaist/taxi-back into #…
5369fe0 
…273-안-읽은-메세지-확인
@chlehdwon
Merge branch 'dev' of https://github.com/sparcs-kaist/taxi-back into #…
63896a3 
…273-안-읽은-메세지-확인
@chlehdwon
Merge branch 'dev' of https://github.com/sparcs-kaist/taxi-back into #…
37b514b 
…273-안-읽은-메세지-확인
@chlehdwon
Refactor: apply prettier
f81a2f9
@chlehdwon
Add: partInfoHandler
52b5747
@chlehdwon
Refactor: change updateChatHandler to readChatHandler
b41425b
@chlehdwon
Remove: partInfoHandler
92cab6a
@chlehdwon
Remove: parameter userId in emitUpdateEvent
3737777
@chlehdwon
Fix: disconnectSocket channel
455497a
@chlehdwon
Fix: change endpoint of readChatHandler
9859916
@chlehdwon
Remove: import formatSettlement
0d1a745
@chlehdwon chlehdwon requested a review from 14KGun September 5, 2023 14:51
@14KGun 14KGun marked this pull request as ready for review September 6, 2023 04:23
14KGun
14KGun reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~

src/modules/auths/login.js Show resolved Hide resolved
src/modules/stores/mongo.js Outdated Show resolved Hide resolved
src/routes/chats.js Outdated Show resolved Hide resolved
src/modules/socket.js Outdated Show resolved Hide resolved
src/services/chats.js Outdated Show resolved Hide resolved
@14KGun
Copy link
Member

14KGun commented Sep 6, 2023

front 작업 이후 같이 머지되면 좋을 것 같아요 @chlehdwon

@14KGun 14KGun requested review from kmc7468 and withSang September 19, 2023 06:15
14KGun
14KGun reviewed Sep 19, 2023
View reviewed changes
src/modules/socket.js Outdated Show resolved Hide resolved
src/modules/stores/mongo.js Outdated Show resolved Hide resolved
src/services/chats.js Outdated Show resolved Hide resolved
src/services/chats.js Outdated Show resolved Hide resolved
src/services/chats.js Show resolved Hide resolved
@14KGun
Copy link
Member

14KGun commented Sep 19, 2023

@chlehdwon 브랜치 업데이트 부탁드려요 !!

kmc7468
kmc7468 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 건님이 남겨주신 코멘트만 해결되면 머지돼도 좋을 것 같습니다.

14KGun
14KGun approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다 ~

src/services/chats.js Outdated Show resolved Hide resolved
14KGun
14KGun approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

@chlehdwon chlehdwon merged commit c5cf10a into dev Sep 24, 2023
@chlehdwon chlehdwon deleted the #273-안-읽은-메세지-확인 branch September 24, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmc7468 kmc7468 kmc7468 approved these changes

@14KGun 14KGun 14KGun approved these changes

@withSang withSang Awaiting requested review from withSang

Assignees

@chlehdwon chlehdwon

Labels
chatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

안 읽은 메시지 확인
4 participants
@chlehdwon @14KGun @kmc7468 @withSang