Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#341 2023 가을학기 추석 홍보 이벤트 위한 transactions #364
#341 2023 가을학기 추석 홍보 이벤트 위한 transactions #364
Changes from 15 commits
f8b7df1
b5238d7
f047d85
f190d7c
13a42ca
6c387ea
f6c3b94
6326969
7d943f2
cebd609
04b6fe1
153ffb2
69c0f81
74206dd
ce6a30a
b5dc891
0d5d0e1
ee6dace
f07ba8d
ee3c625
9ed166c
431af7b
868d9b7
103b46a
b5a1f77
c0d6649
5c2ac3c
e514be4
54457fd
39816d2
5f5b103
8558aa3
23ed5d9
fce261f
fdcf582
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠...ㅋㅋㅋㅋ 나중에 컨벤션 바꿔서
module.exports.requestFirstLoginEvent = async () => { ...
이런식으로 수정되면 더 깔끔할 것 같긴하네요..@withSang 나중에 타입스크립트 도입할 때에는
es6
import
export
해주세요 ㅠㅜThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return value가 지금은 안 쓰이는 것 같은데 추가하신 이유가 혹시 있을지 궁금해요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재는 삭제된 instagramRewardAction 쪽에서 transactionId를 이용하여 Admin Log를 남겼었습니다. 나중에 필요한 일이 있을까봐 반환값은 그대로 유지하였습니다!