Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#188 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가, #428 Redis 연결 실패 시 재시도 추가 #429

Merged
merged 5 commits into from
Nov 9, 2023
Merged

#188 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가, #428 Redis 연결 실패 시 재시도 추가 #429

merged 5 commits into from
Nov 9, 2023

Conversation

withSang
Copy link
Member

@withSang withSang commented Nov 7, 2023 •
edited
Loading

Summary

It fixes #188, fixes #428

  • 세션 쿠키의 maxAge를 "브라우저 세션 종료"에서 2주로 수정합니다.
  • production 환경에서 secure cookie(MDN 문서 참조)를 설정합니다.
  • 기존의 rolling 정책(매 요청 시마다 쿠키의 expiry 연장)을 삭제합니다. 14일은 이미 충분히 길기 때문입니다. 필요 시 rolling을 다시 사용할 수 있습니다.
  • session storage로 사용하는 Redis 서버와의 연결이 끊겼을 때 Node 프로세스가 비정상적으로 종료되는 문제를 수정합니다.

Images or Screenshots

image
session id cookie의 expiry가 2주로 설정됨

Further Work

  • 없음.

@withSang withSang linked an issue Nov 7, 2023 that may be closed by this pull request
로그인 만료 시간이 너무 짧음 #188
Closed
1 task
@withSang withSang requested review from 14KGun, kmc7468 and cokia and removed request for 14KGun November 7, 2023 11:15
@withSang withSang self-assigned this Nov 7, 2023
@withSang withSang added 😱 bug Something isn't working authentication labels Nov 7, 2023
@withSang withSang marked this pull request as draft November 7, 2023 11:47
@14KGun 14KGun requested a review from chlehdwon November 7, 2023 12:13
@withSang withSang marked this pull request as ready for review November 7, 2023 12:38
14KGun
14KGun approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@14KGun 14KGun changed the title 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가 #188 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가 Nov 8, 2023
@withSang withSang changed the title #188 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가 #188 로그인 만료 시간이 너무 짧음 - cookie의 expiry 추가, #428 Redis 연결 실패 시 재시도 추가 Nov 8, 2023
cokia
cokia approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@cokia cokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다 :)

@withSang withSang merged commit d4893b0 into dev Nov 9, 2023
1 check passed
@withSang withSang deleted the #188.3-set-session-expiry branch November 9, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@14KGun 14KGun 14KGun approved these changes

@cokia cokia cokia approved these changes

@kmc7468 kmc7468 Awaiting requested review from kmc7468

@chlehdwon chlehdwon Awaiting requested review from chlehdwon

Assignees

@withSang withSang

Labels
authentication 😱 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Redis 연결 실패 시 재시도 추가 로그인 만료 시간이 너무 짧음
3 participants
@withSang @cokia @14KGun