Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#441 방 생성 시각의 유효성을 검사하지 않는 버그 #459

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

chlehdwon
Copy link
Contributor

@chlehdwon chlehdwon commented Feb 12, 2024

Summary

It closes #441

Extra info

간단하게 request의 timestamp와 출발 시각을 비교하여, timestamp가 출발 시각 이후인 경우 error를 반환합니다.
아래를 보시면 1:30 이후에 방 생성을 잘 막아주는 걸 알 수 있습니다.

Images or Screenshots

image

Further Work

  • Do something...

@chlehdwon chlehdwon self-assigned this Feb 12, 2024
@chlehdwon chlehdwon added the 😱 bug Something isn't working label Feb 12, 2024
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 짧은 오류가 있었다니! 해결해주셔서 감사드립니다.

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@chlehdwon chlehdwon merged commit 2e6af9d into dev Feb 13, 2024
1 check passed
@chlehdwon chlehdwon deleted the #441-rooms-create-time-validation branch February 13, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working rooms router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

방 생성 시각의 유효성을 검사하지 않는 버그
3 participants