Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#486 [Bug] loginReplacePage 임시 수정 #487

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

chlehdwon
Copy link
Contributor

Summary

It closes #486

@chlehdwon chlehdwon requested review from kmc7468 and withSang March 5, 2024 14:29
@chlehdwon chlehdwon self-assigned this Mar 5, 2024
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이렇게 쓰고 있었는데 잘 돼요!
수정해주셔서 감사드립니다!!
localhost:9000과 localhost:3000/api 사이의 혼선을 피하기 위해 프론트엔드 vite.config.ts 파일의 api_base도 /api로 통일할 필요가 있겠습니다.

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

논의가 필요하겠지만, 개인적인 의견으로는 프론트에서 라우팅을 해주시면 좋을 것 같습니다.

@chlehdwon
Copy link
Contributor Author

빠른 의견 모두 감사합니다 :) 추후 이 관련 문제 생길 때 해당 리뷰 기반으로 다시 논의 시작하면 될 것 같아요!~!

@chlehdwon chlehdwon merged commit 58bf58b into dev Mar 5, 2024
1 check passed
@chlehdwon chlehdwon deleted the #486-bug-fix-login-replace-page branch March 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] loginReplacePage 임시 수정
3 participants