#516 blockedlist #519
Merged
#516 blockedlist #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
TaehyeonPark
requested review from
kmc7468,
withSang and
14KGun
and removed request for
kmc7468 and
withSang
kmc7468
reviewed
May 21, 2024
chlehdwon
requested changes
May 21, 2024
kmc7468
requested changes
May 27, 2024
src/routes/users.js
Outdated
| // 유저의 서비스 정지 여부를 반환합니다. | ||
| router.get("/isBanned", userHandlers.isBannedHandler); | ||
|
|
||
| // 유저의 서비스 정지 여부를 반환합니다. |
kmc7468
reviewed
May 27, 2024
src/routes/docs/users.js
Outdated
| properties: { | ||
| userId: { | ||
| type: "string", | ||
| description: "사용자의 UUID", |
There was a problem hiding this comment.
UUID 보다는 단순히 Object ID라고 하는 것이 더 적절한 표현일 것 같아요!
kmc7468
reviewed
May 27, 2024
src/services/users.js
Outdated
| }, | ||
| }); | ||
| if (!result) { | ||
| return res.status(400).json("Users/isBanned : there is no ban record"); |
There was a problem hiding this comment.
빈 Array는 true로 평가되기 때문에, 이 부분은 사실 500 Internal Server Error로 생각하는게 더 좋을 것 같습니다.
kmc7468
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #516
ban관련 모든 api는/usersrouter의 하위 api로 동작합니다./users/isBanned/users/getBanRecord