Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#558 [Bug] Dockerfile이 올바르지 않음 #559

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

kmc7468
Copy link
Member

@kmc7468 kmc7468 commented Nov 26, 2024

Summary

It closes #558
TypeScript에 맞춰서, 빌드를 한 후 실행하도록 Dockerfile을 수정하였습니다. 이미지 용량을 줄이기 위해 2 Stage Build를 도입하였습니다.

@kmc7468 kmc7468 added the 😱 bug Something isn't working label Nov 26, 2024
@kmc7468 kmc7468 requested a review from TaehyeonPark November 26, 2024 19:26
@kmc7468 kmc7468 self-assigned this Nov 26, 2024
@kmc7468 kmc7468 linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link
Contributor

@TaehyeonPark TaehyeonPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmc7468 kmc7468 merged commit 13cc0d4 into dev Nov 26, 2024
1 check passed
@kmc7468 kmc7468 deleted the 558-update-dockerfile-for-typescript branch November 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Dockerfile이 올바르지 않음
2 participants