Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect offsets during assignments with broadcasts #1875

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix incorrect offsets during assignments with broadcasts #1875

merged 2 commits into from
Jan 22, 2025

Conversation

phschaad
Copy link
Collaborator

No description provided.

@phschaad phschaad requested a review from tbennun January 16, 2025 10:31
tbennun
tbennun requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test / parameterize split_test

@phschaad phschaad requested a review from tbennun January 21, 2025 10:05
@tbennun tbennun added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 855fc27 Jan 22, 2025
9 checks passed
@tbennun tbennun deleted the users/phschaad/assignment_offset_fix branch January 22, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @tbennun