Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reset to initial image #11

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pietrobs
Copy link

@pietrobs pietrobs commented Jun 9, 2022

No description provided.

@pietrobs pietrobs mentioned this pull request Jun 9, 2022
@@ -226,6 +237,12 @@ class _CropperState extends State<Cropper> {
);
}

void setImageToInitialState() {
setState(() {
widget.image = widget.initialImage;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird updating the widget's image here in the state when the image is not really updated. Wouldn't it be cleaner if we can reset the transformations on the image instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants