Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): Enable opentelemetry for the Spin shim #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Jan 29, 2025

This enables the opentelemetry feature from the containerd-shim-wasm which provides otel for the shim process. Before containerd-shim-wasm v0.9.0, the container process would inherit the otel runtime from the shim process, and thus causing a conflict with the spin telemetry runtime. Now, the container process was initialized (a.k.a zygote process) at the very begining when the shim process is in a clean state, and so it is free to initialize it's own otel runtime.

This PR builds on top of #271

FYI @calebschoepp

Example

image

Base automatically changed from bump-containerd-shim-wasm to main January 30, 2025 00:47
@kate-goldenring
Copy link
Collaborator

@Mossaka what is the flow for configuring an OTEL ingester in your example? I am assuming that otel config needs to be passed somewhere else besides the container spec

@Mossaka
Copy link
Collaborator Author

Mossaka commented Jan 30, 2025

@Mossaka what is the flow for configuring an OTEL ingester in your example?

It's passed down by containerd. https://github.com/containerd/runwasi/blob/main/docs/opentelemetry.md

@Mossaka Mossaka closed this Jan 31, 2025
@Mossaka Mossaka reopened this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants