Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reference to raw content for sample app #147

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

lechnerc77
Copy link
Contributor

This PR contains a minor fix of the documentation for deploying SpinKube on a AKS cluster. The current description for applying the configuration of the sample app:

kubectl apply -f https://github.com/spinkube/spin-operator/blob/main/config/samples/simple.yaml

leads to the following error:

error: error parsing https://github.com/spinkube/spin-operator/blob/main/config/samples/simple.yaml: error converting YAML to JSON: yaml: line 206: mapping values are not allowed in this context

The PR changes the statement to point to the raw content on GitHub which fixes the error from above

Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @lechnerc77!

@vdice vdice merged commit c1587da into spinkube:main Apr 8, 2024
1 check passed
@lechnerc77 lechnerc77 deleted the docs/deploy-sample-app branch April 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants