fix "click to copy" not copying content #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fisher <[email protected]>
Signed-off-by: Matthew Fisher <[email protected]>
vdice
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Copying now works! 🎉
One thing we'll want to look at next: performing a snippet 'audit' to remove extra text that would prevent successful pasting/execution (like the $'s in https://spinkube.dev/docs/install/rancher-desktop/#step-4-deploying-your-application) -- or signaling that the snippet shouldn't be copy/paste-able (for instance maybe it shows command output and is meant to serve more as a reference).
|
I agree. I'd love to add that in a follow-up. |
|
filed #220 to track that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ReferenceError: Cannot access 'copyCode' before initialization.Also fixes the issue where "click to copy" was not being applied to the code block unless its parent had the
data-plausibleattribute applied.