-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micromagnetics #599
Draft
MSallermann
wants to merge
51
commits into
develop
Choose a base branch
from
fixed-micromagnetic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Micromagnetics #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class does not have any real functionality yet. A corresponding input parser has been added, but the kind and units of input parameters still need to be decided.
Added Constants_Micromagnetic namespace. Also added Joule to other constants namespaces.
This will later be used to change it at runtime, especially enabling one to switch between atomistic and micromagnetic calculations. Also potentially fixed a crashing bug in the copy constructors of Spin_System: the geometry shared pointer of the Hamiltonian was not set correctly on copy.
Also added the ability to switch between Hamiltonians from the GUI.
- the API now allows switching to Hamiltonian_Heisenberg - the GUI was not updating the corresponding tab correctly, potentially leading to crashes - the CUDA backend of Hamiltonian_Micromagnetic can now be compiled
Anisotropy, exchange and DMI. The implementation of the energy calculation is tentative. Also added some logging of micromagnetic input parser.
-fixed anisotropy, exchange DMI - passing skyrmion convergence test now
- moved DDI_Method enum class to Hamiltonian.hpp - added settings for dipolar interactions to micromagnetic Hamiltonian - added some micromagnetic parameters to Hamiltonian API and made some minor improvements - made external field consistent for micromagnetic Hamiltonian
…ian (to match mu_s in atomistic case). Also added cell_volume to Geometry and changed definition of cell_size (from bounds_max - bounds_min to actual cell_size). Now these fields might also have some use in the atomistic case.
- Implemented E_DDI_Direct - corrected periodic boundary conditions in Gradient_DDI_Direct - fixed set_ddi API function
- Improved implementation of Gradient_Exchange - Implemented Gradient_DMI - Added both to unit test
GPMueller
reviewed
Jul 1, 2021
GPMueller
reviewed
Jul 1, 2021
Comment on lines
+317
to
+328
**Units:** | ||
|
||
In the micromagnetic model, Spirit uses SI units: | ||
- `m` (meter) for distances | ||
- `J` (Joule) for energies | ||
- `s` (second) for time | ||
|
||
Therefore, | ||
- `A [J/m]` for exchange stiffness | ||
- `D [J/m^2]` for DMI | ||
- `K [J/m^3]` for anisotropy | ||
- `Ms [A/m]` for saturation magnetisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a section like this to the Heisenberg Hamiltonian documentation. IMO it it is quite useful to have this overview in the beginning
5 tasks
GPMueller
reviewed
Sep 8, 2021
GPMueller
force-pushed
the
develop
branch
2 times, most recently
from
April 25, 2022 22:01
212372f
to
f49c114
Compare
GPMueller
force-pushed
the
fixed-micromagnetic
branch
from
April 26, 2022 15:56
d39af2f
to
3adf06a
Compare
GPMueller
force-pushed
the
fixed-micromagnetic
branch
from
April 26, 2022 15:59
3adf06a
to
9093d65
Compare
- fix a small copy/paste bug and formatting in Demagnetization_Tensor.hpp - configparser formatting - specify units in comments of `mu_s` API
muellan
force-pushed
the
develop
branch
9 times, most recently
from
June 7, 2023 17:01
63fbd74
to
2edff73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the micromagnetic Hamiltonian.
Todo: