Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespacing for DirectXMath element traits #80

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Fix namespacing for DirectXMath element traits #80

merged 2 commits into from
Nov 16, 2024

Conversation

MattGuerrette
Copy link
Contributor

This commit corrects the namespacing for the DirectXMath element traits as some of the XM types come from the DirectX::PackedVector namespace.

MattGuerrette and others added 2 commits November 16, 2024 11:47
@MattGuerrette
Fix namespacing for DirectXMath element traits
d820384 
This commit corrects the namespacing for the DirectXMath element traits
as some of the XM types come from the DirectX::PackedVector namespace.
@spnda
Explicitly include DirectXPackedVector.h and add unsigned byte vectors
49fab01
@spnda
Copy link
Owner

spnda commented Nov 16, 2024

Great, thank you. Sorry about that...
I added a second commit that also includes DirectXPackedVector.h if its available, since the PackedVector namespace is only defined there. Also added the XMUBYTEN and corrected the XMSHORTN specializations.

@spnda spnda merged commit 48b3ac7 into spnda:main Nov 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattGuerrette @spnda