MockMaker API cleanup #1868
Merged
MockMaker API cleanup #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
============================================
+ Coverage 80.38% 80.44% +0.06%
- Complexity 4316 4335 +19
============================================
Files 439 441 +2
Lines 13518 13529 +11
Branches 1709 1705 -4
============================================
+ Hits 10867 10884 +17
+ Misses 2011 2007 -4
+ Partials 640 638 -2 ☔ View full report in Codecov by Sentry. |
leonard84
requested changes
Jan 24, 2024
spock-core/src/main/java/org/spockframework/mock/runtime/MockCreationSettings.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/mock/runtime/MockMakerRegistry.java
Outdated
Show resolved
Hide resolved
| * @param id the mock maker ID. | ||
| * @return the settings object | ||
| */ | ||
| static IMockMakerSettings simple(MockMakerId id) { |
There was a problem hiding this comment.
Thinking some more about it, I'm not happy with the simple name.
It suggests that we are configuring some kind of simple mock maker.
Maybe a forId or builtIn would be more precise. Or, we should lift the anonymous class to a top-level named IdOnlySettings and remove the static method here, as we don't want users to use this method directly.
There was a problem hiding this comment.
Ich have changed the name to settingsFor().
...cs/src/test/groovy/org/spockframework/mock/runtime/ByteBuddyMockFactoryConcurrentSpec.groovy
Outdated
Show resolved
Hide resolved
...-specs/src/test/groovy/org/spockframework/smoke/mock/InvokingMocksFromMultipleThreads.groovy
Outdated
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/smoke/mock/JavaStubs.groovy
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/smoke/mock/JavaStubs.groovy
Show resolved
Hide resolved
AndreasTu
force-pushed
the
MockitoCleanup
branch
from
618db32 to
585c67e
Compare
Moved MockMakerId to spock.mock package. Added release notes for mock maker feature. Try to ease flaky InvokingMocksFromMultipleThreads spec PollingConditions change: Fix failing test when tests are executed with non english locale. The formatting of the elapsedTime would not match the pattern in the test. Co-authored-by: Leonard Brünings <[email protected]>
AndreasTu
force-pushed
the
MockitoCleanup
branch
from
585c67e to
dfc4a2c
Compare
leonard84
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved MockMakerId to spock.mock package.
Added release notes for mock maker feature.
Try to ease flaky InvokingMocksFromMultipleThreads spec
PollingConditions change: Fix failing test when tests are executed with non english locale.
The formatting of the elapsedTime would not match the pattern in the test.