Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order association (2-4-stable) #334

Merged
merged 4 commits into from
Apr 8, 2016

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 1, 2016

Rebase of #332 on 2-4-stable. Resolves #306.

@Mafi88
Copy link
Contributor

Mafi88 commented Apr 4, 2016

CircleCi and Travis specs are failing... could you please look into it?

@mvz
Copy link
Contributor Author

mvz commented Apr 4, 2016

@Mafi88 I'll take a look.

@mvz
Copy link
Contributor Author

mvz commented Apr 4, 2016

@Mafi88 it looks like 2-4-stable's build is itself broken: https://travis-ci.org/spree/spree_auth_devise/builds/116355413. I'm having a go at fixing it in #335.

@mvz
Copy link
Contributor Author

mvz commented Apr 4, 2016

@Mafi88 I have no idea why the CircleCI build started succeeding, but #335 fixes the 2-4-stable build. Once that's merged, I can rebase this PR and the build should succeed.

@damianlegawiec damianlegawiec merged commit 5a3857f into spree:2-4-stable Apr 8, 2016
@damianlegawiec
Copy link
Member

Thanks @mvz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants