Refine @SuppressWarnings("NullAway")

See gh-28797
spring-projects · Jan 8, 2025 · a73a819 · a73a819
1 parent 82941ca
commit a73a819
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/...ns/src/main/java/org/springframework/beans/factory/config/FieldRetrievingFactoryBean.java b/...ns/src/main/java/org/springframework/beans/factory/config/FieldRetrievingFactoryBean.java
@@ -158,7 +158,7 @@ public void setBeanClassLoader(ClassLoader classLoader) {
 
 
 	@Override
-	@SuppressWarnings("NullAway") // Lazy initialization
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	public void afterPropertiesSet() throws ClassNotFoundException, NoSuchFieldException {
 		if (this.targetClass != null && this.targetObject != null) {
 			throw new IllegalArgumentException("Specify either targetClass or targetObject, not both");

diff --git a/...ng-jdbc/src/main/java/org/springframework/jdbc/datasource/SingleConnectionDataSource.java b/...ng-jdbc/src/main/java/org/springframework/jdbc/datasource/SingleConnectionDataSource.java
@@ -179,7 +179,7 @@ public void setAutoCommit(boolean autoCommit) {
 
 
 	@Override
-	@SuppressWarnings("NullAway") // Lazy initialization
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	public Connection getConnection() throws SQLException {
 		this.connectionLock.lock();
 		try {

diff --git a/...c/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseFactory.java b/...c/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseFactory.java
@@ -159,7 +159,7 @@ public void setDatabasePopulator(DatabasePopulator populator) {
 	 * Factory method that returns the {@linkplain EmbeddedDatabase embedded database}
 	 * instance, which is also a {@link DataSource}.
 	 */
-	@SuppressWarnings("NullAway") // Lazy initialization
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	public EmbeddedDatabase getDatabase() {
 		if (this.dataSource == null) {
 			initDatabase();

diff --git a/.../java/org/springframework/jdbc/support/incrementer/AbstractColumnMaxValueIncrementer.java b/.../java/org/springframework/jdbc/support/incrementer/AbstractColumnMaxValueIncrementer.java
@@ -43,7 +43,7 @@ public abstract class AbstractColumnMaxValueIncrementer extends AbstractDataFiel
 	 * @see #setIncrementerName
 	 * @see #setColumnName
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway.Init")
 	public AbstractColumnMaxValueIncrementer() {
 	}
 

diff --git a/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java b/spring-jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java
@@ -323,7 +323,7 @@ private ConnectionFactory obtainTargetConnectionFactory() {
 	 * @throws jakarta.jms.JMSException if thrown by JMS API methods
 	 * @see #initConnection()
 	 */
-	@SuppressWarnings("NullAway") // Lazy initialization
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	protected Connection getConnection() throws JMSException {
 		this.connectionLock.lock();
 		try {

diff --git a/...g-jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java b/...g-jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java
@@ -1434,7 +1434,7 @@ private void decreaseActiveInvokerCount() {
 			}
 		}
 
-		@SuppressWarnings("NullAway") // Lazy initialization
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		private void initResourcesIfNecessary() throws JMSException {
 			if (getCacheLevel() <= CACHE_CONNECTION) {
 				updateRecoveryMarker();