Advice argument binding failure when enabling AspectJ mode for transactions

[JoshuaChen]

After enabling @EnableTransactionManagement(mode = AdviceMode.ASPECTJ, proxyTargetClass = true), an exception occurs.

java.lang.IllegalStateException: Expecting to find 3 arguments to bind by name in advice, but actually found 2 arguments

The issue seems to be that AspectJ has changed its logic, and the first element in aspectJAdviceMethod.getParameterTypes() no longer returns JoinPoint, causing the exception.

2025-01-24T22:15:06.825+08:00 DEBUG 85696 --- [           main] .s.a.a.a.ReflectiveAspectJAdvisorFactory : Found AspectJ method: public java.lang.Object org.springframework.transaction.aspectj.AbstractTransactionAspect.ajc$around$org_springframework_transaction_aspectj_AbstractTransactionAspect$1$2a73e96c(java.lang.Object,org.aspectj.runtime.internal.AroundClosure,org.aspectj.lang.JoinPoint$StaticPart)
2025-01-24T22:15:06.825+08:00 DEBUG 85696 --- [           main] .s.a.a.a.ReflectiveAspectJAdvisorFactory : Ignoring incompatible advice method: public java.lang.Object org.springframework.transaction.aspectj.AbstractTransactionAspect.ajc$around$org_springframework_transaction_aspectj_AbstractTransactionAspect$1$2a73e96c(java.lang.Object,org.aspectj.runtime.internal.AroundClosure,org.aspectj.lang.JoinPoint$StaticPart)

java.lang.IllegalStateException: Expecting to find 3 arguments to bind by name in advice, but actually found 2 arguments.
	at org.springframework.aop.aspectj.AbstractAspectJAdvice.bindExplicitArguments(AbstractAspectJAdvice.java:472) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.AbstractAspectJAdvice.bindArgumentsByName(AbstractAspectJAdvice.java:438) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.AbstractAspectJAdvice.calculateArgumentBindings(AbstractAspectJAdvice.java:389) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.ReflectiveAspectJAdvisorFactory.getAdvice(ReflectiveAspectJAdvisorFactory.java:314) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.InstantiationModelAwarePointcutAdvisorImpl.instantiateAdvice(InstantiationModelAwarePointcutAdvisorImpl.java:152) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.InstantiationModelAwarePointcutAdvisorImpl.<init>(InstantiationModelAwarePointcutAdvisorImpl.java:116) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.ReflectiveAspectJAdvisorFactory.getAdvisor(ReflectiveAspectJAdvisorFactory.java:217) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.ReflectiveAspectJAdvisorFactory.getAdvisors(ReflectiveAspectJAdvisorFactory.java:146) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.BeanFactoryAspectJAdvisorsBuilder.buildAspectJAdvisors(BeanFactoryAspectJAdvisorsBuilder.java:116) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.annotation.AnnotationAwareAspectJAutoProxyCreator.findCandidateAdvisors(AnnotationAwareAspectJAutoProxyCreator.java:95) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.aspectj.autoproxy.AspectJAwareAdvisorAutoProxyCreator.shouldSkip(AspectJAwareAdvisorAutoProxyCreator.java:105) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.aop.framework.autoproxy.AbstractAutoProxyCreator.postProcessBeforeInstantiation(AbstractAutoProxyCreator.java:280) ~[spring-aop-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInstantiation(AbstractAutowireCapableBeanFactory.java:1150) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.resolveBeforeInstantiation(AbstractAutowireCapableBeanFactory.java:1125) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:512) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:336) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:289) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:334) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:204) ~[spring-beans-6.2.1.jar:6.2.1]
	at org.springframework.context.support.PostProcessorRegistrationDelegate.registerBeanPostProcessors(PostProcessorRegistrationDelegate.java:277) ~[spring-context-6.2.1.jar:6.2.1]
	at org.springframework.context.support.AbstractApplicationContext.registerBeanPostProcessors(AbstractApplicationContext.java:808) ~[spring-context-6.2.1.jar:6.2.1]
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:611) ~[spring-context-6.2.1.jar:6.2.1]
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:146) ~[spring-boot-3.4.1.jar:3.4.1]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:752) ~[spring-boot-3.4.1.jar:3.4.1]
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:439) ~[spring-boot-3.4.1.jar:3.4.1]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:318) ~[spring-boot-3.4.1.jar:3.4.1]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1361) ~[spring-boot-3.4.1.jar:3.4.1]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1350) ~[spring-boot-3.4.1.jar:3.4.1]
	at com.example.demo.DemoApplication.main(DemoApplication.java:17) ~[classes/:na]

[sbrannen]

Hi @JoshuaChen,

Congratulations on submitting your first PR for the Spring Framework!. 👍

The issue seems to be that AspectJ has changed its logic, and the first element in aspectJAdviceMethod.getParameterTypes() no longer returns JoinPoint, causing the exception.

How did you come to the conclusion?

Please provide an example that worked with a previous version of AspectJ and began to fail with a recent version of AspectJ (for example 1.9.22.1 which we currently support).

In addition, you will need to introduce a JUnit-Jupiter based test in the test suite that covers this scenario.

Thanks

[JoshuaChen]

hi~
Based on the original logic,

Class<?> firstArgType = this.aspectJAdviceMethod.getParameterTypes()[0];

AspectJ should return JoinPoint in the first parameter. However, when I ran and debugged it in my own demo app, I saw that it returned JoinPoint in the last element of getParameterTypes().
Therefore, I concluded that AspectJ has changed its logic.
To prevent AspectJ from changing the logic again and to maintain compatibility with previous versions, I used a loop to fix it.

Additionally, please give me some time to provide unit tests, and I will try to complete them.

[JoshuaChen]

hi~ @sbrannen

You are correct, this exception is not related to the AspectJ version.

I found that version 6.1.6 does not trigger the exception, but version 6.1.7 does. The change to isAspect() in version 6.1.7 (#32793) opened Pandora’s box. The “Advice argument binding failure” issue has always existed; it just wasn’t triggered before.

In version 6.1.6 and earlier (apologies, I couldn’t test all versions), there was no handling for the corresponding AspectJ method, so it “worked normally.”

Additionally, unit tests have been added. Please help me review the code.