Tenancies #418
Tenancies #418
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| teamId String @default(uuid()) @db.Uuid | ||
| // Team IDs must be unique across all organizations (but not necessarily across all branches). | ||
| // To model this in the DB, we add two columns that are always equal to tenancy.projectId and tenancy.branchId. | ||
| mirroredProjectId String |
There was a problem hiding this comment.
Why do we call these mirroredProjectId instead of just projectId
There was a problem hiding this comment.
Because they're not the source of truth, they are just a mirror. Like a cache
apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/webhooks/page-client.tsx
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| export default function PageClient() { | ||
| const stackAdminApp = useAdminApp(); | ||
| const svixToken = stackAdminApp.useSvixToken(); | ||
| const [updateCounter, setUpdateCounter] = useState(0); | ||
|
|
||
| // This is a hack to make sure svix hooks update when content changes |
There was a problem hiding this comment.
Are you sure that after removing this code, the manual Svix API requests are refreshed?
There was a problem hiding this comment.
I haven't tested it but I'd be surprised if it didn't, I added key={updateCounter}
| const { payload } = await jose.jwtVerify(accessToken, jwks); | ||
| expect(payload).toEqual({ | ||
| "exp": expect.any(Number), | ||
| "iat": expect.any(Number), | ||
| "iss": "https://access-token.jwt-signature.stack-auth.com", | ||
| "aud": expect.any(String), | ||
| "sub": expect.any(String), | ||
| "branchId": "main", |
There was a problem hiding this comment.
Are we going to have a different secret key per branch in the future?
There was a problem hiding this comment.
What would the purpose of that be?
| * eventually, we'll nicely pass around tenancies and won't need this function anymore, so the cache is a good temp | ||
| * solution | ||
| */ | ||
| const soleTenancyIdsCache = new Map<string, string>(); |
There was a problem hiding this comment.
Is it problematic if we delete a tenancy?
There was a problem hiding this comment.
that would only happen if we delete the associated Project
Co-authored-by: Zai Shi <[email protected]>
…/webhooks/page-client.tsx Co-authored-by: Zai Shi <[email protected]>
Adds Tenancies to the database schema. This is the name of the concept that's
Project x Branch x Environment x Organization.For now, this adds a
tenancyproperty to SmartRequestAuth. Later, in the "Make all endpoints support organizations" step, we want to get rid of this, as onlyprojectIdandbranchIdare known by SmartRequest (each endpoint may use a different strategy to pick the organization — usually based on the user ID, but can be anything). However, for now, it makes the transition much easier.Important
Introduces 'Tenancies' to support multi-tenancy, affecting database schema, authentication, and API handling.
Tenancytable inmigration.sqlto representProject x Branch x Environment x Organization.migration.sqlto usetenancyIdinstead ofprojectId.ProjectConfigOverridetable.tenancyproperty toSmartRequestAuthinsmart-request.tsx.createAuthTokens()andgenerateAccessToken()intokens.tsxto usetenancy.OAuthModelinmodel.tsxto handletenancyfor token operations.crud-handler.tsxto supporttenancy.verification-code-handler.tsxto usetenancy.parseAuth()insmart-request.tsxto includetenancyin authentication context.errors.tsxto accommodate new tenancy logic.backend-helpers.tsto validate tenancy-related changes.page-client.tsxandutils.tsxfor webhooks.This description was created by
for 60f6231. It will automatically update as commits are pushed.