Skip to content

Commit

Permalink
default skiplist height same as original leveldb which had 4M write b…
Browse files Browse the repository at this point in the history
…uffers. Raising to 17 to match Basho. Have seen 5% improvement in bsbm100m create. (#9)

Co-authored-by: MatthewVon <[email protected]>
  • Loading branch information
matthewvon and MatthewVon authored Jun 12, 2020
1 parent a7d2e8d commit 5cb1595
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion memtable/inlineskiplist.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class InlineSkipList {
// in the allocator must remain allocated for the lifetime of the
// skiplist object.
explicit InlineSkipList(Comparator cmp, Allocator* allocator,
int32_t max_height = 12,
int32_t max_height = 17,
int32_t branching_factor = 4);

// Allocates a key and a skip-list node, returning a pointer to the key
Expand Down
2 changes: 1 addition & 1 deletion memtable/skiplist.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class SkipList {
// and will allocate memory using "*allocator". Objects allocated in the
// allocator must remain allocated for the lifetime of the skiplist object.
explicit SkipList(Comparator cmp, Allocator* allocator,
int32_t max_height = 12, int32_t branching_factor = 4);
int32_t max_height = 17, int32_t branching_factor = 4);

// Insert key into the list.
// REQUIRES: nothing that compares equal to key is currently in the list.
Expand Down

0 comments on commit 5cb1595

Please sign in to comment.