Added failure for bad types in building an executable.

[orizi]

Stack:

• Added failure for bad types in building an executable. #7129 ⬅
• Added panic print in executable run. #7145

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

                // Emulated builtins are not supported in compilation for executable.
                return Err(BuildError::DisallowedBuiltinForExecutable(generic_ty.clone()));
            }

I'm guessing
!config.outputting_function
means test mode, but it a bad name in that case.
Maybe add another configuration flag?

Suggestion:

            if config.outputting_function {
                // Emulated builtins are not supported when compiling an executable.
                return Err(BuildError::DisallowedBuiltinForExecutable(generic_ty.clone()));
            }

[orizi]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I'm guessing
!config.outputting_function
means test mode, but it a bad name in that case.
Maybe add another configuration flag?

Done.

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, orizi wrote…

Done.

What about the conditioning on outputting_function? at least explain it.

[ilyalesokhin-starkware]

Reviewed 2 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, all discussions resolved

[orizi]

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

What about the conditioning on outputting_function? at least explain it.

it basically means that emulation makes no sense if we are actually using the output builtin.
trying to add some more info.
Done maybe?

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, orizi wrote…

it basically means that emulation makes no sense if we are actually using the output builtin.
trying to add some more info.
Done maybe?

"if we use the output builtin, no emulated builtins are allowed."
what does this mean?

[orizi]

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

"if we use the output builtin, no emulated builtins are allowed."
what does this mean?

if we use the output builtin (which is the meaning of the outputting_function flag) - we it means we are actually proving something - so no emulation is required.

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, orizi wrote…

if we use the output builtin (which is the meaning of the outputting_function flag) - we it means we are actually proving something - so no emulation is required.

the comment above outputting_function does not say anything about proving.

also I would argue that the name of the flag is wrong if it means that this is going to be proved

[orizi]

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

the comment above outputting_function does not say anything about proving.

also I would argue that the name of the flag is wrong if it means that this is going to be proved

how about now?

[ilyalesokhin-starkware]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 377 at r1 (raw file):

Previously, orizi wrote…

how about now?

Nice

[orizi]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)