-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(corelib): Iterator::Sum #7142
feat(corelib): Iterator::Sum #7142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, all commit messages.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)
a discussion (no related file):
@ilyalesokhin-starkware for 2nd eye.
corelib/src/test/iter_test.cairo
line 83 at r1 (raw file):
let mut iter = array![].into_iter(); let sum: usize = iter.sum(); assert_eq!(sum, 0);
Suggestion:
assert_eq!(array![1, 2, 3].into_iter().sum(), 6);
assert_eq!(array![].into_iter().sum(), 0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)
c73bb2d
to
3183113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)
a discussion (no related file):
Previously, orizi wrote…
@ilyalesokhin-starkware for 2nd eye.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)
Sums an iterator