-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(consensus): move network parameters into consensus config #3130
chore(consensus): move network parameters into consensus config #3130
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/starknet_consensus_manager/src/consensus_manager.rs
line 22 at r1 (raw file):
// TODO(Dan, Guy): move to config. // pub const BROADCAST_BUFFER_SIZE: usize = 100;
dont forget to remove :)
ee9fa2d
to
bcabfe7
Compare
dec918d
to
c1414f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)
crates/starknet_consensus_manager/src/consensus_manager.rs
line 22 at r1 (raw file):
Previously, asmaastarkware (asmaa-starkware) wrote…
dont forget to remove :)
Thanks!
bcabfe7
to
7078ff6
Compare
c1414f4
to
17326cc
Compare
7078ff6
to
9f1b01c
Compare
17326cc
to
0a7bb60
Compare
Artifacts upload workflows: |
9f1b01c
to
8d4f147
Compare
0a7bb60
to
22c3068
Compare
22c3068
to
360cbf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @asmaastarkware and @guy-starkware)
crates/sequencing/papyrus_consensus/src/config.rs
line 55 at r2 (raw file):
pub proposals_topic: String, /// Name of the topic for vote messages. pub votes_topic: String,
Why are we putting these into the consensus config? The plan is to put them into a new config struct for the node ConsensusManagerConfig/PapyrusConsensusConfig
Code quote:
/// The buffer size of each channel, for votes channel and proposals channel.
pub broadcast_buffer_size: usize,
/// Name of the topic for streaming proposals.
pub proposals_topic: String,
/// Name of the topic for vote messages.
pub votes_topic: String,
d94f865
to
174e78f
Compare
174e78f
to
6df7549
Compare
Moved a few parameters used in consensus from constants into config fields.