refactor(papyrus_protobuf): align proto files with p2p-specs #3227
+1,891
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlonLStarkWare
commented
Jan 9, 2025
AlonLStarkWare
commented
- chore: external and internal transaction wrappers
- fix(starknet_api): changed the L1HandlerTransaction to the struct with a tx_hash
- fix(starknet_api): cr comments
- refactor(papyrus_protobuf): align common.proto
AlonLStarkWare
requested review from
ShahakShama,
eitanm-starkware and
noamsp-starkware
|
This change is |
AlonLStarkWare
changed the title
…saction with empty hash
AlonLStarkWare
force-pushed
the
alonl/proto_alignment_with_p2p_specs
branch
from
5fe4933 to
b285e13
Compare
AlonLStarkWare
force-pushed
the
alonl/proto_alignment_with_p2p_specs
branch
from
4e62362 to
02d3ba0
Compare
…nsaction in consensus and MempoolTransaction
…on and converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.