-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace TestSubscriberChannels struct with tuple #3251
base: main
Are you sure you want to change the base?
Conversation
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware, @noamsp-starkware, and @ShahakShama)
crates/papyrus_network/src/network_manager/test_utils.rs
line 276 at r1 (raw file):
} // pub struct TestSubscriberChannels<T: TryFrom<Bytes>> {
Remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r1, all commit messages.
Reviewable status: 7 of 9 files reviewed, 4 unresolved discussions (waiting on @AlonLStarkWare, @eitanm-starkware, and @noamsp-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/papyrus_consensus_context_test.rs
line 128 at r1 (raw file):
.unwrap(); let (voting_channels, mock_voting_network) = mock_register_broadcast_topic().unwrap();
@matan-starkware or @guy-starkware should approve this file
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context_test.rs
line 81 at r1 (raw file):
cende_ambassador: MockCendeContext, ) -> (SequencerConsensusContext, NetworkDependencies) { let (subscriber_channels, mock_proposal_stream_network) =
@matan-starkware or @guy-starkware should approve this file
crates/papyrus_network/src/network_manager/test_utils.rs
line 276 at r1 (raw file):
} // pub struct TestSubscriberChannels<T: TryFrom<Bytes>> {
Remove this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, 3 unresolved discussions (waiting on @eitanm-starkware, @guy-starkware, @matan-starkware, @noamsp-starkware, and @ShahakShama)
crates/papyrus_network/src/network_manager/test_utils.rs
line 276 at r1 (raw file):
Previously, ShahakShama wrote…
Remove this code
Done.
39568c6
to
072abc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed 2 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AlonLStarkWare, @eitanm-starkware, @matan-starkware, @noamsp-starkware, and @ShahakShama)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AlonLStarkWare, @eitanm-starkware, @matan-starkware, and @noamsp-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware, @matan-starkware, and @noamsp-starkware)
No description provided.