test(starknet_consensus_orchestrator): return central object intead o…

[DvirYo-starkware]

…f json values in utilities cende test

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 550 at r2 (raw file):

}

fn central_transaction_execution_info_with_reverted(

it is not always with reverted.

Code quote:

fn central_transaction_execution_info_with_reverted

[DvirYo-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 550 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

it is not always with reverted.

Plese write what you think is appropriate name for the function you comment about

[Yael-Starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @DvirYo-starkware)

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 493 at r2 (raw file):

// the entire object, we fill only one CallInfo with non-default values and the other CallInfos are
// None.
fn central_transaction_execution_info() -> TransactionExecutionInfo {

Suggestion:

fn transaction_execution_info() -> TransactionExecutionInfo {

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 504 at r2 (raw file):

                balance_high: felt!(3_u8),
            },
        )),

Suggestion:

        revert_error: None,

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 563 at r2 (raw file):

    transaction_execution_info.into()
}

Suggestion:

fn central_transaction_execution_info_reverted(
) -> CentralTransactionExecutionInfo {
    let mut transaction_execution_info = central_transaction_execution_info();
    // The python side enforces that if the transaction is reverted, the execute_call_info is None.
    // Since we are using the same json files for python tests, we apply these rules here as well.
    transaction_execution_info.execute_call_info = None;
    transaction_execution_info.revert_error = Some(RevertError::PostExecution(
            FeeCheckError::InsufficientFeeTokenBalance {
                fee: Fee(1),
                balance_low: felt!(2_u8),
                balance_high: felt!(3_u8),
            },
        ));

    transaction_execution_info.into()
}

fn central_transaction_execution_info(
) -> CentralTransactionExecutionInfo {
        transaction_execution_info.into()
}

[DvirYo-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Yael-Starkware)

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 493 at r2 (raw file):

// the entire object, we fill only one CallInfo with non-default values and the other CallInfos are
// None.
fn central_transaction_execution_info() -> TransactionExecutionInfo {

Done.

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 504 at r2 (raw file):

                balance_high: felt!(3_u8),
            },
        )),

Done.

---

crates/starknet_consensus_orchestrator/src/cende/central_objects_test.rs line 563 at r2 (raw file):

    transaction_execution_info.into()
}

Done.

[Yael-Starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)