feat(starknet_sequencer_metrics): define required metrics for the remote servers

[lev-starkware]

Stack:

• refactor(starknet_sequencer_metrics,starknet_sequencer_node): adjust … #4262
• feat(starknet_sequencer_infra,starknet_sequencer_node): finalize adding metrics to remote servers #4248
• feat(starknet_sequencer_node): instantiate the bundling struct for every remote servers #4245
• feat(starknet_sequencer_infra): create a structure that bundles remote server metrics #4244
• feat(starknet_sequencer_metrics): define required metrics for the remote servers #4243 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 124 at r1 (raw file):

    MetricScope::Infra => {
        // Local server counters
        { BATCHER_MSGS_RECEIVED, "batcher_msgs_received", "Counter of messages received by batcher component", 0 },

Please add a todo to rename these so they are consistent with the remote ones:
BATCHER_MSGS_RECEIVED -> BATCHER_LOCAL_MSGS_RECEIVED

The metric name and description as well.
You can address that in later pr on the top of this stack

Code quote:

{ BATCHER_MSGS_RECEIVED, "batcher_msgs_received"

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @lev-starkware)

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 143 at r1 (raw file):

        { BATCHER_REMOTE_MSGS_RECEIVED, "batcher_remote_msgs_received", "Counter of messages received by batcher remote server", 0 },
        { BATCHER_REMOTE_VALID_MSGS_RECEIVED, "batcher_remote_valid_msgs_received", "Counter of valid messages received by batcher remote server", 0 },
        { BATCHER_REMOTE_MSGS_PROCESSED, "batcher_remote_msgs_processed", "Counter of messages  processed by batcher remote server", 0 },

Is there a way to make this a fn that takes only the name and produces the literal? Maybe a const fn?

Code quote:

Counter of messages  processed by batcher remote server

[lev-starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 124 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add a todo to rename these so they are consistent with the remote ones:
BATCHER_MSGS_RECEIVED -> BATCHER_LOCAL_MSGS_RECEIVED

The metric name and description as well.
You can address that in later pr on the top of this stack

Done.

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 143 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Is there a way to make this a fn that takes only the name and produces the literal? Maybe a const fn?

Sorry, I don't understand exactly what you are proposing.

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

✓ Commit merged in pull request #4262