Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starknet_consensus_orchestrator): remove panic if block info invalid #4249

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

matan-starkware
Copy link
Contributor

This was leftover for testing purposes. Since blockinfo is an external input it can be invalid.

This was leftover for testing purposes. Since blockinfo is an external input it can be invalid.
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@matan-starkware matan-starkware marked this pull request as ready for review February 18, 2025 19:24
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Contributor Author

matan-starkware commented Feb 20, 2025

Merge activity

  • Feb 20, 1:33 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 20, 1:33 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@matan-starkware matan-starkware added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 089e182 Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants