Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txn_with_hash component and update ws api #250

Open
wants to merge 2 commits into
base: v0.8.0
Choose a base branch
from
Open

Add txn_with_hash component and update ws api #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f94b29
Add txn_with_hash component and update ws api
amanusk Nov 17, 2024
431e671
Merge conflicts with v0.8.0
amanusk Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 25 additions & 50 deletions api/starknet_api_openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,22 +312,7 @@
"result": {
"name": "result",
"schema": {
"title": "Transaction",
"allOf": [
{
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "#/components/schemas/TXN_HASH"
}
},
"required": ["transaction_hash"]
}
]
"$ref": "#/components/schemas/TXN_WITH_HASH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too indented (other such references, too).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the indentation is messed up, once we finalize 0.8.0 we'll merge the prettifier PR to align on indentation (pun intended)

}
},
"errors": [
Expand Down Expand Up @@ -364,22 +349,7 @@
"result": {
"name": "transactionResult",
"schema": {
"title": "Transaction",
"allOf": [
{
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "#/components/schemas/TXN_HASH"
}
},
"required": ["transaction_hash"]
}
]
"$ref": "#/components/schemas/TXN_WITH_HASH"
}
},
"errors": [
Expand Down Expand Up @@ -1511,24 +1481,9 @@
"description": "The transactions in this block",
"type": "array",
"items": {
"title": "transactions in block",
"type": "object",
"allOf": [
{
"title": "transaction",
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "#/components/schemas/TXN_HASH"
}
},
"required": ["transaction_hash"]
}
]
"schema": {
"$ref": "#/components/schemas/TXN_WITH_HASH"
}
}
}
},
Expand Down Expand Up @@ -1890,6 +1845,26 @@
}
]
},
"TXN_WITH_HASH": {
"schema": {
"title": "Transaction",
"allOf": [
{
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "#/components/schemas/TXN_HASH"
}
},
"required": ["transaction_hash"]
}
]
}
},
"SIGNATURE": {
"title": "Signature",
"description": "A transaction signature",
Expand Down
20 changes: 2 additions & 18 deletions api/starknet_ws_api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,23 +244,7 @@
"$ref": "./api/starknet_api_openrpc.json#/components/schemas/TXN_HASH"
},
{
"allOf": [
{
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"transaction_hash": {
"title": "transaction hash",
"$ref": "./api/starknet_api_openrpc.json#/components/schemas/TXN_HASH"
}
},
"required": [
"transaction_hash"
]
}
]
"$ref": "./api/starknet_api_openrpc.json#/components/schemas/TXN_WITH_HASH"
}
]
}
Expand Down Expand Up @@ -390,4 +374,4 @@
}
}
}
}
}