depending on newer dapla-toolbelt for dependabot #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arneso-ssb
reviewed
Mar 4, 2024
.github/workflows/tests.yml
Outdated
| @@ -141,7 +141,7 @@ jobs: | |||
| - name: Download coverage data | |||
| uses: actions/download-artifact@v4 | |||
| with: | |||
| name: coverage-data | |||
| name: coverage-data-ubuntu-latest-3.10 | |||
There was a problem hiding this comment.
No need to hardcode. Use cruft update to update template with fixes for this, Or look at https://github.com/statisticsnorway/ssb-pypitemplate-instance/blob/main/.github/workflows/tests.yml#L143-L147
|
arneso-ssb
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions regularly fail, because artifacts are being overwritten to the same location with v4 of actions/upload-artifact@v4
This is a workaround, where the OS and pythonversion is appended to the artifact names to avoid collision.
The worst part is how "ubuntu-latest-3.10" is hard-coded... Would be nice to be able to do something like
{{ matrix.os[0] }}but I dont think thats possible...Also @sebrothe reported that his mypy was having a hard time understanding my "dynamic imports" in __init__.py so I rewrote it to a more common python syntax, actually listing things twice... (Which was what I was trying to avoid.)