Update RPM related stuff to 4.16.1.3

[Thaodan]

• Clean file follow flycheck

(cherry picked from commit ​4fdad909b8d2d47b9d776d4fadecb38a6f6bc6be)

• Pulled from: zzndb@4fdad90

[jn64]

Most of the functions changed here don't work for me on Emacs 28.2. Specifically, all of the functions that have no arguments after the removal of &optional arg, but still contain (interactive "p"), don't work when called interactively with M-x.

For example doing M-x rpm-insert-tag results in this error:

funcall-interactively: Wrong number of arguments: ((t) nil "Insert or change a tag." (interactive "p") (if current-prefix-arg (rpm-change) (rpm-insert))), 1

Should the (interactive "p") for those functions with no args be changed to (interactive)? It seems to fix the problem for me, but I don't fully understand the implication of the "p".

---

I also had to pick e95001c to get the package working at all. So the problem can be repro'd with master + e95001c + 93259f7 (this PR) on Emacs 28.2.

Same with the version at https://github.com/Thaodan/rpm-spec-mode/tree/thaodan/personal_merger, meaning the other collected patches don't affect this problem.

[jn64]

I guess this is why @zzndb reverted most of these changes in zzndb@9fd1536 (leaving only the changes actually related to RPM 4.16.1.3). Problem is solved by picking zzndb@9fd1536 on top of previously mentioned.

You might want to pick that for https://github.com/Thaodan/rpm-spec-mode/tree/thaodan/personal_merger too.

[Thaodan]

Can amend the PR with the revert squashed in. To be honest I haven't tested Emacs 28.2

[jn64]

Do you mean that the functions work for you when called interactively? And on what version of Emacs? Anyway no hurry to update the PR. I will study more on interactive functions and try to fix it up properly. It looks like maybe rpm-insert-tags is the only function that needs `(interactive "p")` as it makes use of the prefix arg; the rest of the functions could have both args and "p" removed.

[Thaodan]

Do you mean that the functions work for you when called interactively? And on what version of Emacs?

Sorry for the late reply. I didn't test, the functions did not work fine, I just didn't test all of the changes.
I reverted the changes that were causing the errors.