Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow sign in with email #100

Merged
merged 11 commits into from
Jan 19, 2025
Merged

feat: allow sign in with email #100

merged 11 commits into from
Jan 19, 2025

Conversation

stonith404
Copy link
Owner

@stonith404 stonith404 commented Jan 6, 2025

This feature resolves #18 which suggest that users should be able to sign in with an link sent to their email. This function is only recommended for environment where security isn't a big concern like hosting it in the local network.

The feature has to be enabled in the settings:
image

@samiralam
Copy link

Seems to work as advertised!

Some feedback:

  • Suggest changing the link text from "You don't have access to your passkey?" to "Don't have access to your passkey?" as a more natural English phrase
  • Recommend adding the ability to enable email logins separately from email notifications; currently there's no way to enable the first while disabling the second. While "new device" email notifications are a good idea, currently it sends an email every time I login, even from the same device, which gets a bit spammy.

@stonith404
Copy link
Owner Author

@samiralam Thanks for your feedback. These two changes are now implemented in the latest stonith404/pocket-id:dev-email-login image.

@stonith404 stonith404 marked this pull request as ready for review January 18, 2025 21:56
@samiralam
Copy link

samiralam commented Jan 18, 2025

Pulled the new image and retested:

  • Updated link text
  • Email login link redirects to client after logging in
  • Email notifications can be enabled separately from email logins

Looks great!

@stonith404 stonith404 merged commit 06b90ed into main Jan 19, 2025
6 checks passed
@stonith404 stonith404 deleted the feature/email-sign-in branch January 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Fallback auth?
2 participants