Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branch selector #2518

Merged
merged 4 commits into from
Feb 5, 2024
Merged

fix: branch selector #2518

merged 4 commits into from
Feb 5, 2024

Conversation

mallachari
Copy link

@mallachari mallachari commented Feb 1, 2024

Fixes STOP-94
Fixes rendering two StoplightProject components due to matching both routes.

The API for listBranches has changed for elements-dev-portal v2 introducing slightly different response format.
It still responds with previous data structure for all elements-dev-portal v1 instances so its users are not affected.

Changes:

  • updates response data type to follow new format
  • adds Switch to router to prioritize rules - currently /:nodeSlug+ rule matches all paths (because of + sign)

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 07fda7e
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/65bc26574b44060008d7209f
😎 Deploy Preview https://deploy-preview-2518--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 07fda7e
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/65bc2657e91cf30008a10b9c
😎 Deploy Preview https://deploy-preview-2518--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 10032fe
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/65c0f1c086f4a3000878f013
😎 Deploy Preview https://deploy-preview-2518--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 10032fe
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/65c0f1c0d4e129000805cc00
😎 Deploy Preview https://deploy-preview-2518--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mallachari mallachari marked this pull request as ready for review February 1, 2024 23:26
@mallachari mallachari requested a review from a team as a code owner February 1, 2024 23:26
@mallachari mallachari requested review from P0lip and daniel-white and removed request for P0lip February 1, 2024 23:26
@mallachari mallachari merged commit 1059ccb into main Feb 5, 2024
7 checks passed
@mallachari mallachari deleted the fix/branch-selector branch February 5, 2024 14:58
AhalyaPai pushed a commit to jpmorganchase/elemental that referenced this pull request Feb 18, 2025
* fix: branch selector

* chore: release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants