-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Boot Vitest runner when hovering the Testing Module #29387
base: unified-ui-testing
Are you sure you want to change the base?
Conversation
…t when this event happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0353fab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased, since tests were failing. Otherwise, LGTM
Adds a new
TESTING_MODULE_BOOT_REQUEST
event which is emitted when hovering the Testing Module. The Vitest manager is booted when this event fires, so that it's ready when a test run is started. This saves about 1.5-2 seconds on my Macbook Pro M1.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This pull request introduces a new event
TESTING_MODULE_BOOT_REQUEST
to improve the performance of the Vitest runner in Storybook. The key changes include:TESTING_MODULE_BOOT_REQUEST
event tocode/core/src/core-events/index.ts
TESTING_MODULE_BOOT_REQUEST
incode/addons/test/src/preset.ts
bootTestProviders
function inSidebarBottom
component to emit the new event on hovercode/core/src/manager/globals/exports.ts
to include the new event in globalized dependenciesexecute
function in test preset to accept an optionaleventName
parameterThese changes aim to preemptively boot the Vitest runner when hovering over the Testing Module, potentially saving 1.5-2 seconds of loading time.