CLI: Add "intents" question & auto-install test addon & improve test-addon compatibility #30202
+2,624
−487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit baec739.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 56 | 59 | 🚨 +3 🚨 |
| Self size | 332 KB | 228 KB | 🎉 -104 KB 🎉 |
| Dependency size | 12.71 MB | 13.47 MB | 🚨 +755 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/core
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 54 | 54 | 0 |
| Self size | 19.22 MB | 18.98 MB | 🎉 -240 KB 🎉 |
| Dependency size | 14.44 MB | 14.44 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 55 | 55 | 0 |
| Self size | 22 KB | 23 KB | 🚨 +1 KB 🚨 |
| Dependency size | 33.66 MB | 33.42 MB | 🎉 -240 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 56 | 56 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 33.68 MB | 33.44 MB | 🎉 -239 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 359 | 🎉 -29 🎉 |
| Self size | 503 KB | 261 KB | 🎉 -242 KB 🎉 |
| Dependency size | 75.54 MB | 83.84 MB | 🚨 +8.30 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 277 | 277 | 0 |
| Self size | 617 KB | 617 KB | 0 B |
| Dependency size | 65.62 MB | 65.38 MB | 🎉 -240 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 113 | 7 | 🎉 -106 🎉 |
| Self size | 1.11 MB | 10.27 MB | 🚨 +9.16 MB 🚨 |
| Dependency size | 42.79 MB | 2.24 MB | 🎉 -40.55 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
…t reproduce locally
…/storybook into norbert/cli-with-ink
…/storybook into norbert/cli-with-ink
…e file if we cannot update the config file
…/storybook into norbert/cli-with-ink
… get replaced by the experimental-addon-test
…for our own CI, to be able to keep testing NextJS. NOrmally the test intent would be enabled by default, but the postinstall would then migrate the nextjs framework to experimental-nextjs-vite framework, thus not allowing us to keep testing the nextjs framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30202-sha-f7878745. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-30202-sha-f7878745norbert/cli-with-inkf78787451738703332)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30202Greptile Summary
This PR significantly enhances the Storybook CLI with new features for test addon integration and improved framework compatibility checks.
code/lib/create-storybook/src/initiate.tscode/lib/create-storybook/src/ink/steps/checks/frameworkTest.tsxcode/lib/create-storybook/src/ink/steps/checks/vitestConfigFiles.tsxcode/lib/create-storybook/src/bin/modernInputs.tsThe changes look comprehensive but the commented-out render functions in several new files suggest some UI components may not be fully implemented yet.