-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Patch 8.5.2 #30374
Merged
Merged
Release: Patch 8.5.2 #30374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…es-vitest-3 Addon Test: Support Vitest 3 browser.test.instances field (cherry picked from commit 4d2989d)
This reverts commit f70e832.
Docs: Set init/upgrade snippets to latest on latest
Build: Update lock file
…207908875 CLI: Corrected Next.js createScript for pnpm. (cherry picked from commit 3d390e2)
github-actions
bot
added
the
release
For PRs that trigger new releases. Automated
label
Jan 24, 2025
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
January 24, 2025 13:59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…es-vitest-3 Addon Test: Support Vitest 3 browser.test.instances field (cherry picked from commit 4d2989d)
View your CI Pipeline Execution ↗ for commit 6d20a3d.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
added
ci:daily
Run the CI jobs that normally run in the daily job.
and removed
ci:normal
labels
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.1
to8.5.2
.Once this pull request is merged, it will trigger a new release of version
8.5.2
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x 4d2989d48746f04220bddf27d2ceec9f966343bd
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.2
Greptile Summary
Based on the provided information, I'll create a concise summary of this patch release:
Patch release 8.5.2 containing two bug fixes to improve compatibility and project initialization:
browser.test.instances
field in test addon, replacing deprecatedbrowser.name
configurationnext-app^14
tonext-app@^14
The changes are appropriate for a patch release as they:
Note: The documentation changes from
@next
to@latest
in init/upgrade commands should be reviewed as they may be inconsistent with a patch release's scope.