New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan Level 1 #215

Merged

JJJ merged 4 commits into stuttter:master from lloc:chore/phpstan-level-1

Feb 25, 2025

Contributor

lloc commented Feb 10, 2025 •

edited

Loading

Setting PHPStan to level 1 revealed three minor issues, which have been addressed in this PR:

Ignored the warning: "Constant WP_CONTENT_URL not found."
Fixed: "Variable $slug in empty() always exists and is not falsy." ( array_filter has been applied before.)
Fixed: "Variable $rows might not be defined."

lloc added 4 commits

February 10, 2025 18:03


          Fixes 'Variable might not be defined.'

601f1d0


          Fixes 'Variable in empty() always exists and is not falsy.' (array_fi…

f85dc0d

…lter has been applied)


          Ignores 'Constant WP_CONTENT_URL not found.'

3a1800a


          Fixes sniff-php issues

0d6bb5e

Contributor Author

lloc commented Feb 24, 2025

@JJJ @spacedmonkey Do you think we can get those changes in? I would like to go ahead and raise the level. ;-)

JJJ merged commit d32478f into stuttter:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet