Skip plotting line data if it's all NaNs #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DanRyanIrish
reviewed
Jan 8, 2025
| @@ -145,7 +145,9 @@ def _plot_1D_cube(self, wcs, axes=None, axes_coordinates=None, axes_units=None, | |||
| # We plot against pixel coordinates | |||
| axes.errorbar(np.arange(len(ydata)), ydata, yerr=yerror, **kwargs) | |||
| else: | |||
| axes.plot(ydata, **kwargs) | |||
| # compute() will break on numpy arrays to catch dask arrays by casting to bool instead | |||
There was a problem hiding this comment.
This comment should make more sense to those who aren't dask wonks ;)
DanRyanIrish
reviewed
Jan 8, 2025
| @@ -0,0 +1 @@ | |||
| Skip plotting line data if all values are NaN | |||
There was a problem hiding this comment.
Suggested change
| Skip plotting line data if all values are NaN | |
| Make `~ndcube.visualization.mpl_plotter.MatplotlibPlotter` only add data to line plots if at least one value of the data is unmasked and finite. |
| @@ -145,7 +145,9 @@ def _plot_1D_cube(self, wcs, axes=None, axes_coordinates=None, axes_units=None, | |||
| # We plot against pixel coordinates | |||
| axes.errorbar(np.arange(len(ydata)), ydata, yerr=yerror, **kwargs) | |||
| else: | |||
| axes.plot(ydata, **kwargs) | |||
| # compute() will break on numpy arrays to catch dask arrays by casting to bool instead | |||
| if not bool(np.isnan(ydata).all()): | |||
There was a problem hiding this comment.
Could something like
Suggested change
| if not bool(np.isnan(ydata).all()): | |
| if np.isfinite(ydata).any() and unmasked: |
be used instead without causing dask problems? This way both NaN and Inf would be checked. In addition, it would check whether there are valid unmasked data because unmasked would be a bool that would indicate that at least one finite data value is unmasked and default to True. It would be calculated around here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DKISTDC/dkist#477
Over in the DKIST python tools I discovered that trying to line plot a slice of a dataset took many times longer if there was no actual data there. This skips the attempt to actually plot a line full of NaNs which should solve that and cause no other problems anywhere, probably.