Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tokio dependency to dev-dependencies #3

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Move tokio dependency to dev-dependencies #3

merged 1 commit into from
Oct 14, 2024

Conversation

strykejern
Copy link
Contributor

It's not used in library directly, only in tests, and the dependency does not compile for wasm.

@strykejern
Move tokio dependency to dev-dependencies
0b8d134 
It's not used in library directly, only in tests, and the dependency
does not compile for wasm
Proziam
Proziam approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Proziam Proziam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

EDIT: This passes all tests locally but not in CI. I'm going to merge it and then investigate.

@Proziam Proziam merged commit 42d60f0 into supabase-community:main Oct 14, 2024
1 check failed
@strykejern strykejern deleted the tokio-dependency-fix branch October 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Proziam Proziam Proziam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strykejern @Proziam