-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add modernizer check for assertEquals(Iterable, Iterable[, String])
This prevents false positive test results when comparing iterables (most notably: MaterializedResult instances) due to TestNG bug (testng-team/testng#543). False-positive results were found in ~20 tests and are fixed in the following commits.
- Loading branch information
1 parent
832c177
commit 0c5cffa
Showing
3 changed files
with
18 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?xml version="1.0"?> | ||
<modernizer> | ||
<violation> | ||
<name>org/testng/Assert.assertEquals:(Ljava/lang/Iterable;Ljava/lang/Iterable;)V</name> | ||
<version>1.8</version> | ||
<comment>Use com.facebook.presto.testing.assertions.Assert.assertEquals due to TestNG #543</comment> | ||
</violation> | ||
|
||
<violation> | ||
<name>org/testng/Assert.assertEquals:(Ljava/lang/Iterable;Ljava/lang/Iterable;Ljava/lang/String;)V</name> | ||
<version>1.8</version> | ||
<comment>Use com.facebook.presto.testing.assertions.Assert.assertEquals due to TestNG #543</comment> | ||
</violation> | ||
</modernizer> |