Update ci.yml (#783)

* Update ci.yml * seems to work
sveltejs · Nov 9, 2023 · 61ae116 · 61ae116
1 parent 31ce52c
commit 61ae116
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,10 +6,12 @@ on:
     branches:
       - main
       - v1
+      - v2
   pull_request:
     branches:
       - main
       - v1
+      - v2
 env:
   # we call `pnpm playwright install` instead
   PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -5,6 +5,7 @@ on:
     branches:
       - main
       - v1
+      - v2
 permissions: {}
 
 jobs:

diff --git a/packages/vite-plugin-svelte/src/index.js b/packages/vite-plugin-svelte/src/index.js
@@ -296,6 +296,7 @@ export function svelte(inlineOptions) {
 					return;
 				}
 				try {
+					// @ts-ignore doesn't exist in Svelte 4
 					const compileResult = await svelteCompiler.compileModule(code, {
 						generate: ssr ? 'ssr' : 'dom',
 						filename: moduleRequest.filename

diff --git a/packages/vite-plugin-svelte/src/utils/esbuild.js b/packages/vite-plugin-svelte/src/utils/esbuild.js
@@ -62,6 +62,7 @@ export function esbuildSveltePlugin(options) {
 async function compileSvelte(options, { filename, code }, statsCollection) {
 	if (isSvelte5 && filename.endsWith(svelteModuleExtension)) {
 		const endStat = statsCollection?.start(filename);
+		// @ts-ignore doesn't exist in Svelte 4
 		const compiled = svelte.compileModule(code, {
 			filename,
 			generate: 'dom',
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,7 @@ on: @@
         branches:
           - main
           - v1
+          - v2
     permissions: {}
     jobs:
@@ Expand Down @@