Skip to content

Commit

Permalink
ci: test node 22 lts (#1023)
Browse files Browse the repository at this point in the history
  • Loading branch information
bluwy authored Nov 15, 2024
1 parent 364b7d1 commit e2232ba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# build and test on linux, windows, mac with node 18,20
name: CI

on:
Expand All @@ -22,15 +21,15 @@ permissions:
contents: read # to fetch code (actions/checkout)

jobs:
# "checks" job runs on linux + 16 only and checks that install, build, lint and audit work
# "checks" job runs on linux + node lts only and checks that install, build, lint and audit work
# it also primes the pnpm store cache for linux, important for downstream tests
checks:
timeout-minutes: 5
runs-on: ${{ matrix.os }}
strategy:
matrix:
# pseudo-matrix for convenience, NEVER use more than a single combination
node: [20]
node: [22]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -68,18 +67,19 @@ jobs:
if: (${{ success() }} || ${{ failure() }})
run: pnpm generate:types && [ "`git status --porcelain=v1`" == "" ]

# "test" job runs on linux, windows, mac with node active lts and linux with node maintenance lts
test:
timeout-minutes: 10
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
node: [20]
node: [22]
os: [ubuntu-latest, macos-latest, windows-latest]
include:
- node: 18
os: ubuntu-latest
- node: 22
- node: 20
os: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
# pseudo-matrix for convenience, NEVER use more than a single combination
node: [20]
node: [22]
os: [ubuntu-latest]
steps:
- name: checkout
Expand Down

0 comments on commit e2232ba

Please sign in to comment.