Fix source maps #857
Open
Fix source maps #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848
Improves upon the original fix in #726 that broke the source maps for non inline cases.
Note: only one of sourceMap or inlineSourceMap can be on at the same time in tsconfig, so this checks for inline, and if not set falls back to evaluating the sourceMap opiton.
on snapshot update
The snapshot is now correct. The correct line for the error is 30:5:
This error is thrown in line 30 here:
Would you like me to work on a dedicated test for testing inlineSourceMap? Didn't naturally fit into the current test suite, but could definitely whip something up.