Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add (experimental) nodejs interop crates #9974

Merged
merged 27 commits into from
Jan 29, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 29, 2025

Description:

I'm experimenting with various options

@kdy1 kdy1 added this to the Planned milestone Jan 29, 2025
@kdy1 kdy1 self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: d09c9c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title chore: Initialize nodejs interop crates feat: Add nodejs interop crates Jan 29, 2025
@kdy1 kdy1 marked this pull request as ready for review January 29, 2025 22:33
@kdy1 kdy1 requested a review from a team as a code owner January 29, 2025 22:33
@kdy1 kdy1 enabled auto-merge (squash) January 29, 2025 22:33
@kdy1 kdy1 disabled auto-merge January 29, 2025 22:33
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 29, 2025
@kdy1 kdy1 enabled auto-merge (squash) January 29, 2025 22:33
@kdy1 kdy1 changed the title feat: Add nodejs interop crates feat: Add (experimental) nodejs interop crates Jan 29, 2025
@kdy1 kdy1 disabled auto-merge January 29, 2025 22:52
@kdy1 kdy1 merged commit 37e0ea5 into swc-project:main Jan 29, 2025
169 checks passed
@kdy1 kdy1 deleted the js-babel branch January 29, 2025 22:52
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9974 will degrade performances by 5.12%

Comparing kdy1:js-babel (d3d366c) with main (ca8a71f)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 121.6 ms 128.2 ms -5.12%
es/lints/libs/react 1.8 ms 1.6 ms +9.29%
es/minifier/libs/jquery 161.5 ms 156 ms +3.52%
es/minifier/libs/lodash 197.8 ms 205.6 ms -3.75%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant