fix(es/parser, es/codegen): Handle trailing empty slots in array patterns

[magic-akari]

Related issue:

• Closes: minifier: incorrectly remove comma in ArrayAssignmentPattern of Destructing Assignment #9921

[changeset-bot]

🦋 Changeset detected

Latest commit: 8701c60

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[magic-akari]

failures:

---- identity____swc_ecma_parser__tests__test262_parser__pass__5e7ca8611aaa4d53_js stdout ----
Input: /home/runner/work/swc/swc/crates/swc_ecma_parser/tests/test262-parser/pass/5e7ca8611aaa4d53.js


========== Running codegen test 5e7ca8611aaa4d53.js
Source:
let [a,,]=1


Pos: BytePos(1) ~ BytePos(13) (L1)
Expected code:
let[a,,]=1;
---- Actual -----
Token: 0:4 => 0:3
Token: 0:9 => 0:8
---- Expected -----
Token: 0:7 => 0:6
[crates/swc_ecma_codegen/tests/sourcemap.rs:393:9] &src_map = Vec(
    [
        (
            BytePos(
                1,
            ),
            LineCol {
                line: 0,
                col: 0,
            },
        ),
        (
            BytePos(
                5,
            ),
            LineCol {
                line: 0,
                col: 3,
            },
        ),
        (
            BytePos(
                6,
            ),
            LineCol {
                line: 0,
                col: 4,
            },
        ),
        (
            BytePos(
                10,
            ),
            LineCol {
                line: 0,
                col: 8,
            },
        ),
        (
            BytePos(
                11,
            ),
            LineCol {
                line: 0,
                col: 9,
            },
        ),
    ],
)
----- Visualizer -----
Expected: https://evanw.github.io/source-map-visualization/#MTEAbGV0W2EsLF09MTsxMzAAeyJ2ZXJzaW9uIjozLCJmaWxlIjoiaW5wdXQuanMiLCJzb3VyY2VzIjpbIjAiXSwic291cmNlc0NvbnRlbnQiOlsibGV0IFthLCxdPTFcbiJdLCJuYW1lcyI6WyJhIl0sIm1hcHBpbmdzIjoiQUFBQSxJQUFLQSxFQUFFLEdBQUcifQ==
Actual: https://evanw.github.io/source-map-visualization/#MTEAbGV0W2EsLF09MTsyMDYAeyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIi9ob21lL3J1bm5lci93b3JrL3N3Yy9zd2MvY3JhdGVzL3N3Y19lY21hX3BhcnNlci90ZXN0cy90ZXN0MjYyLXBhcnNlci9wYXNzLzVlN2NhODYxMWFhYTRkNTMuanMiXSwic291cmNlc0NvbnRlbnQiOlsibGV0IFthLCxdPTFcbiJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxHQUFJLENBQUMsSUFBSSxDQUFDIn0=
thread 'identity____swc_ecma_parser__tests__test262_parser__pass__5e7ca8611aaa4d53_js' panicked at crates/swc_ecma_codegen/tests/sourcemap.rs:479:9:
assertion `left == right` failed: col mismatch at 0:6
  left: 7
 right: 5

I'm not very familiar with sourcemap, do you know how to fix it? @kdy1

[kdy1]

Can you add an entry to https://github.com/magic-akari/swc/blob/38801dddf4ef2e583f8622ec09a13178a3eefa48/crates/swc_ecma_codegen/tests/sourcemap.rs#L13 for now?

Fixing source map issue would take some time, so I think it's better to ignore it for a fix for correctness patches about logic.

[codspeed-hq]

CodSpeed Performance Report

Merging #9992 will degrade performances by 3.35%

_{Comparing magic-akari:fix/issue-9921 (8701c60) with main (afe21b5)}

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 194 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	es/full/minify/libraries/jquery	195 ms	201.7 ms	-3.35%
⚡	es/full/minify/libraries/moment	128 ms	120.7 ms	+6%