Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Add tests for context agent #3646

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

sweep-nightly[bot]
Copy link
Contributor

@sweep-nightly sweep-nightly bot commented Apr 30, 2024

Description

This pull request introduces a significant enhancement to the sweepai project by adding unit tests for the context pruning functionality and refactoring the ripgrep command execution into a separate function. These changes aim to improve the maintainability and testability of the codebase, ensuring that the context pruning logic works as expected and can be easily extended in the future.

Summary

  • Refactored the execution of the ripgrep command into a new function run_ripgrep_command in sweepai/core/context_pruning.py to streamline the process of searching code entities within a repository.
  • Added a comprehensive suite of unit tests in tests/test_context_pruning.py covering key functionalities such as building the full hierarchy of files, loading a graph from a file, and retrieving relevant context based on a query. These tests ensure the robustness and reliability of the context pruning feature.
  • Enhanced code readability and maintainability by removing duplicated ripgrep command execution logic and centralizing it into a single, reusable function.
  • The new tests contribute to a safer development environment, allowing for future changes to be made with confidence that the core functionality remains unaffected.

Fixes #3493.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-nightly bot commented Apr 30, 2024

Rollback Files For Sweep

  • Rollback changes to tests/test_context_pruning.py
  • Rollback changes to sweepai/core/context_pruning.py

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-nightly bot commented Apr 30, 2024

Apply Sweep Rules to your PR?

  • Apply: We should use loguru for error logging. If the log is inside an exception, use logger.exception to add tracebacks, where logger is imported from loguru. Use f-strings for string formatting in logger calls (e.g. logger.info(f'Hello {name}') instead of logger.info('Hello {name}', name=name)).
  • Apply: There should be no debug log or print statements in production code.
  • Apply: All functions should have parameters and output annotated with type hints. Use list, tuple and dict instead of typing.List, typing.Tuple and typing.dict.
  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the same directory. For example, sweepai/api_test.py tests sweepai/api.py. Use unittest and unittest.mock as required.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.
  • Apply: Remove any comments before code that are obvious. For example # this prints hello world; print('hello world').

This is an automated message generated by Sweep AI.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sweep-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 1:41am

@sweep-nightly sweep-nightly bot added the sweep Assigns Sweep to an issue or pull request. label Apr 30, 2024
@kevinlu1248 kevinlu1248 merged commit 7c4d276 into main Apr 30, 2024
5 checks passed
@kevinlu1248 kevinlu1248 deleted the sweep/add_tests_for_context_agent_a7026 branch April 30, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for context agent
1 participant